Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
#### What problem is this solving? This PR aims to fix the [Issue #88](#88). An issue generated in release [v0.22.0](https://github.com/vtex-apps/store-image/releases/tag/v0.22.0), which allowed setting the image height of an `image-list` via Admin Site Editor, but set `maxHeight` as default for the image's `height` prop. This distorted the image in accounts that had a value set for maxHeight. With this PR, the image height will no longer receive maxHeight as the default value, requiring the user to set a value for the prop via Admin Site Editor. #### How to test it? Access the [Site Editor](https://vsseixaso--brunoferrini.myvtex.com/admin/cms/site-editor) and follow this sequence of blocks: **HEADER > Header-Desktop > Slider Layout** then click on **Image List**. Then, access any image and set a value in the `Height` field, example: `300px`. Save and apply, now you can see the height of the image is different, but defined by your change, and not by default. #### Screenshots or example usage: [Before](https://vsseixasobugado--brunoferrini.myvtex.com) ![image](https://github.com/user-attachments/assets/3b7009c6-7cd3-433b-800a-7b63dc90bfae) [After](https://vsseixaso--brunoferrini.myvtex.com) ![image](https://github.com/user-attachments/assets/da187287-9cda-455e-a5ad-577ac9eaa996) #### Describe alternatives you've considered, if any. **Follow up**: Add an option to set height for all images in the image-list, for now it's necessary set one by one. #### How does this PR make you feel? [:link:](http://giphy.com/) ![](https://i.giphy.com/media/v1.Y2lkPTc5MGI3NjExeGpubzhrdWRpNXZocjBpNWkyNXd3NjRsbG5wdTh3amdxeHlzbXJxMSZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/S1YVlFY74PCs0CLGfK/giphy.gif)
- Loading branch information