Skip to content

Commit

Permalink
Merge pull request #19 from vtex-apps/feature/make-cms-compliant
Browse files Browse the repository at this point in the history
Feature/make cms compliant
  • Loading branch information
Rafael Klynger authored Jul 10, 2020
2 parents 575294b + 9c0df1d commit 8e8349b
Show file tree
Hide file tree
Showing 7 changed files with 947 additions and 930 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Added
- Title and description to `image` block schema to make it compliant with the new cms.

### Security
- Bump dependency versions.

## [0.4.4] - 2020-05-14
### Fixed
Expand Down
2 changes: 0 additions & 2 deletions messages/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
"admin/editor.store-image.description": "Show any image",
"admin/editor.store-image.src.title": "Image",
"admin/editor.store-image.alt.title": "Alternative text",
"admin/editor.store-image.blockClass.title": "CSS Block Class",
"admin/editor.store-image.blockClass.description": "Adds an extra class name to ease styling",
"admin/editor.store-image.title.title": "Image title",
"admin/editor.store-image.title.description": "Title to be shown on hover",
"admin/editor.image-list.title": "Image List",
Expand Down
4 changes: 1 addition & 3 deletions messages/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
"admin/editor.store-image.description": "Mostrar cualquier imagen",
"admin/editor.store-image.src.title": "Imagen",
"admin/editor.store-image.alt.title": "Texto alternativo",
"admin/editor.store-image.blockClass.title": "CSS Block Class",
"admin/editor.store-image.blockClass.description": "Agrega un nombre de clase extra para facilitar la estilización",
"admin/editor.store-image.title.title": "Título de la imagen",
"admin/editor.store-image.title.description": "Título que se mostrará al pasar el mouse sobre la imagen",
"admin/editor.image-list.title": "Lista de imagenes",
Expand All @@ -25,4 +23,4 @@
"admin/editor.image-slider.slider.showNavigation": "Mostrar flechas de navegación",
"admin/editor.image-slider.slider.showPaginationDots": "Mostrar puntos de paginación",
"admin/editor.image-slider.slider.usePagination": "Usar paginación"
}
}
4 changes: 1 addition & 3 deletions messages/pt.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
"admin/editor.store-image.description": "Exiba qualquer imagem",
"admin/editor.store-image.src.title": "Imagem",
"admin/editor.store-image.alt.title": "Texto alternativo",
"admin/editor.store-image.blockClass.title": "CSS Block Class",
"admin/editor.store-image.blockClass.description": "Adiciona um nome de classe extra para facilitar a estilização",
"admin/editor.store-image.title.title": "Título da imagem",
"admin/editor.store-image.title.description": "Título a ser mostrado quando você passa o mouse pela imagem",
"admin/editor.image-list.title": "Lista de imagens",
Expand All @@ -25,4 +23,4 @@
"admin/editor.image-slider.slider.showNavigation": "Mostrar setas para navegação",
"admin/editor.image-slider.slider.showPaginationDots": "Mostrar indicadores de paginação",
"admin/editor.image-slider.slider.usePagination": "Usar paginação"
}
}
20 changes: 0 additions & 20 deletions react/Image.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -80,35 +80,15 @@ function Image(props: ImageProps) {

const messages = defineMessages({
title: {
defaultMessage: '',
id: 'admin/editor.store-image.title',
},
description: {
defaultMessage: '',
id: 'admin/editor.store-image.description',
},
blockClassTitle: {
defaultMessage: '',
id: 'admin/editor.store-image.blockClass.title',
},
blockClassDescription: {
defaultMessage: '',
id: 'admin/editor.store-image.blockClass.description',
},
})

Image.schema = {
title: messages.title.id,
description: messages.description.id,
type: 'object',
properties: {
blockClass: {
title: messages.blockClassTitle.id,
description: messages.blockClassDescription.id,
type: 'string',
isLayout: true,
},
},
}

export default Image
Loading

0 comments on commit 8e8349b

Please sign in to comment.