Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAX-329] Mobile drawer should be widthfull #6

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

luarakerlen
Copy link
Contributor

What problem is this solving?

Drawer component should have width full for mobile.
It was solved adding vtex.device-detector dependency and using it in ShippingOptionDrawer component.

How to test it?

Workspace

Screenshots or example usage:

Before

Gravacao.de.Tela.2024-09-30.as.15.07.51.mov

After

Gravacao.de.Tela.2024-09-30.as.15.04.42.mov

Related to / Depends on

https://vtex-dev.atlassian.net/browse/SAX-329

Copy link

vtex-io-ci-cd bot commented Sep 30, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@luarakerlen luarakerlen self-assigned this Sep 30, 2024
@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Sep 30, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link
Contributor

@ArthurFerrao ArthurFerrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luarakerlen luarakerlen merged commit daefcd2 into main Oct 1, 2024
5 checks passed
@luarakerlen luarakerlen deleted the SAX-329-drawer-full-width-for-mobile branch October 1, 2024 15:13
Copy link

vtex-io-ci-cd bot commented Oct 1, 2024

Your PR has been merged! App is being published. 🚀
Version 0.1.3 → 0.1.4

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants