Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the country and postalCode to orderForm #5

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

RodrigoTadeuF
Copy link
Contributor

@RodrigoTadeuF RodrigoTadeuF commented Sep 27, 2024

What problem is this solving?

This problem aims to fix one issue that it's currently happening on PLP where on it the postalCode is one and checking on the orderForm the values are null, so to fix it the OrderForm API was added and and update on it was created.

How to test it?

Go to the:
Workspace

And you can check using the following commands:
localStorage.orderform

It will show to you the current value from the orderform, then on the top right corner it an ubicacíon should be set, when the enter button is pressed run again the orderform command and check the postalCode and country values.

Then add a product on the minicart and check if on the cart it's everything working as intended.

Screenshots or example usage:

(PLP)
image
image

(Cart Page)
image
image

Describe alternatives you've considered, if any.

If this is a dangerous deploy to Checkout it should be considered to be added on the Minicart app.

How does this PR make you feel? 🔗

Copy link

vtex-io-ci-cd bot commented Sep 27, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Sep 27, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@vtex-apps vtex-apps deleted a comment from github-actions bot Sep 27, 2024
Copy link

github-actions bot commented Sep 27, 2024

Fails
🚫

👤 Please assign someone to merge this PR, and optionally include people who should review.

Generated by 🚫 dangerJS against 87f5efe

@lpolon
Copy link

lpolon commented Sep 27, 2024

Rodrigo, teste no workspace que você mandou e a chamada está falhando, parece que os dados estão sendo mandados de forma trocada:

  • adicionei um CEP e inspecionei a aba network
  • A chamada para attachments/shippingData retornou 500

Entendi que de fato é a chamada do seu app:
Screenshot 2024-09-27 at 18 10 31

O country está trocado com o orderFormId
Screenshot 2024-09-27 at 18 10 42

E o payload:
Screenshot 2024-09-27 at 18 10 55

@luarakerlen luarakerlen merged commit 9d58bfb into main Oct 2, 2024
4 of 5 checks passed
Copy link

vtex-io-ci-cd bot commented Oct 2, 2024

Your PR has been merged! App is being published. 🚀
Version 0.1.4 → 0.2.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

@luarakerlen luarakerlen deleted the feature/add-orderform-api-call branch October 2, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants