Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing scrollToTop prop to accordion filter #690

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

llfalcao
Copy link

@llfalcao llfalcao commented Nov 29, 2024

What problem is this solving?

The scrollToTop prop isn't passed down to the PriceRange component when the collapsible navigation type is applied to the filter navigator, causing the window to scroll to the top when query params are updated, even when the prop is set to "none".

How to test it?

Using any component that updates the query params with setQuery, from render-runtime.

Workspace (before)
Workspace (after)

Screenshots or example usage:

Before

screen-capture.webm

After

screen-capture.1.webm

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

@llfalcao llfalcao requested review from a team as code owners November 29, 2024 05:12
@llfalcao llfalcao requested review from gabpaladino, vsseixaso and leo-prange-vtex and removed request for a team November 29, 2024 05:12
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 29, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants