Add missing scrollToTop prop to accordion filter #690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
The
scrollToTop
prop isn't passed down to thePriceRange
component when the collapsible navigation type is applied to the filter navigator, causing the window to scroll to the top when query params are updated, even when the prop is set to "none".How to test it?
Using any component that updates the query params with
setQuery
, from render-runtime.Workspace (before)
Workspace (after)
Screenshots or example usage:
Before
screen-capture.webm
After
screen-capture.1.webm
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 🔗