Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactivate search cache #488

Merged
merged 1 commit into from
Feb 9, 2021
Merged

reactivate search cache #488

merged 1 commit into from
Feb 9, 2021

Conversation

hiagolcm
Copy link
Contributor

@hiagolcm hiagolcm commented Feb 9, 2021

What problem is this solving?

Apparently, the cache was hiding a layout problem on search-result pages. This PR is a rollback of this one.

We will solve this definitely after this card. For while this issue will still open

How to test it?

refresh the following page and check if the bug still happening.

workspace

Screenshots or example usage:

Bug:
image

@hiagolcm hiagolcm requested review from a team as code owners February 9, 2021 17:13
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 9, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Feb 9, 2021

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link
Contributor

@iago1501 iago1501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiagolcm hiagolcm merged commit 3d01bed into master Feb 9, 2021
@hiagolcm hiagolcm deleted the bugfix/reactivate-search-cache branch February 9, 2021 17:16
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 9, 2021

Your PR has been merged! App is being published. 🚀
Version 3.93.0 → 3.93.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants