Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/img filter #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feat/img filter #32

wants to merge 3 commits into from

Conversation

jgfidelis
Copy link
Contributor

What problem is this solving?

I want to be able to only get the first image and images with labels to be showed in shelf

How should this be manually tested?

https://imglabels--alssports.myvtex.com

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Clubhouse story (if applicable).
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Screenshots or example usage

Type of changes

✔️ Type of Change
_ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

Notes

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Nov 11, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@jgfidelis jgfidelis requested a review from klzns November 11, 2019 21:15
@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you're not using the Docs Builder properly yet, if you need help to set that up please go to IO Documentation

klzns
klzns previously approved these changes Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants