-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/skip simulation #27
base: master
Are you sure you want to change the base?
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you're not using the Docs Builder properly yet, if you need help to set that up please go to IO Documentation |
} | ||
|
||
public productsRaw = (args: SearchArgs) => { | ||
return this.getRaw<SearchProduct[]>(this.productSearchUrl(args), { | ||
metric: 'search-products', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change metric name to be different from products
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its supposed to be the same thing, just had to do this for typings. Its still hitting the same url with the same variables. For me, it should be the same. I will ask for a third opinion.
node/resolvers/search/index.ts
Outdated
) | ||
} | ||
|
||
const products = await search.products(args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you add skipSimulation = true
to the args
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
...product, | ||
items: product.items.map(item => ({ | ||
...item, | ||
skippedSimulation: !!skipSimulation, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skip simulation is a boolean, !!
isn't needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be null or undefined, lets say someone pass the wrong value in the resolver above the tree. I think this is safer.
de9d04d
to
0bff87b
Compare
What problem is this solving?
How should this be manually tested?
https://fidelis--alssports.myvtex.com/_v/private/[email protected]/graphiql/v1?
Checklist/Reminders
README.md
.CHANGELOG.md
.Screenshots or example usage
Type of changes
Notes