Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: order by prop ReviewDateTime #263

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

choque9
Copy link
Contributor

@choque9 choque9 commented Jul 19, 2024

What problem is this solving?

Fix wrong order in response when reviewDateTime is used. New prop contains same information and returns order as expected

Copy link

vtex-io-ci-cd bot commented Jul 19, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

github-actions bot commented Jul 19, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 9, PR deletions = 0

Generated by 🚫 dangerJS against 6b787b6

@choque9 choque9 requested a review from afmejia23 July 19, 2024 20:33
Copy link
Collaborator

@Mecrano Mecrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mecrano Mecrano merged commit 7bb03d4 into master Jul 22, 2024
10 of 12 checks passed
@Mecrano Mecrano deleted the fix/orderbyReviewDateTime branch July 22, 2024 21:57
Copy link

vtex-io-ci-cd bot commented Jul 22, 2024

Your PR has been merged! App is being published. 🚀
Version 3.15.0 → 3.15.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants