Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use metric instead of logs to reduce log volume #106

Closed
wants to merge 2 commits into from
Closed

Use metric instead of logs to reduce log volume #106

wants to merge 2 commits into from

Conversation

athoscouto
Copy link
Contributor

What problem is this solving?

Related to #99.

How to test it?

vtex link
https://athos--storecomponents.myvtex.com/

@athoscouto athoscouto requested a review from btalma September 16, 2021 22:10
@athoscouto athoscouto requested review from a team as code owners September 16, 2021 22:10
@athoscouto athoscouto requested review from icazevedo, mullerjk and RodrigoTadeuF and removed request for a team September 16, 2021 22:10
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Sep 16, 2021 •
edited by athoscouto
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Sep 16, 2021 •
edited by athoscouto
Loading

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

fabianaferreira
fabianaferreira previously approved these changes Sep 24, 2021
View reviewed changes
Copy link

@fabianaferreira fabianaferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabianaferreira
Copy link

@athoscouto, LGTM. We just need to update the changelog accordingly (:

@athoscouto athoscouto mentioned this pull request Sep 24, 2021
Merged
polishq
polishq requested changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@polishq polishq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase needed

@athoscouto
Copy link
Contributor Author

Feel free to reopen if this is still needed.

@athoscouto athoscouto closed this Mar 8, 2022
@thyarles thyarles deleted the fix/log-volume branch August 4, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polishq polishq polishq requested changes

@wender wender wender approved these changes

@fabianaferreira fabianaferreira fabianaferreira left review comments

@btalma btalma Awaiting requested review from btalma

@icazevedo icazevedo Awaiting requested review from icazevedo

@mullerjk mullerjk Awaiting requested review from mullerjk

@RodrigoTadeuF RodrigoTadeuF Awaiting requested review from RodrigoTadeuF

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@athoscouto @fabianaferreira @wender @polishq