Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSEUS-731] Fixing autocomplete for French #174

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

wender
Copy link
Collaborator

@wender wender commented Nov 5, 2024

What does this PR do? *

It fixes the error when selecting the product in the autocomplete module when the store language is French.
The problem is that the query to get the SKU detail uses product slug that is not translated for the intelligent search, this fix changes it to look for the ID which is immutable and will work for any other language.

How to test it? *

Access https://dev--ronadev.myvtex.com/commande-rapide?__bindingAddress=ronadev.myvtex.com/fr&sc=1
Try to add a product search Jardinière haute en plastique noir DCN Harmony 12 x 18 po
image

Not able to add, gets the graphql error. Only works with english version
image

The change consists on changing the search input to look for the SKU ID instead of the slug
image

Copy link

vtex-io-ci-cd bot commented Nov 5, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Nov 5, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Nov 5, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 54, PR deletions = 56

Generated by 🚫 dangerJS against 76dc0b6

@wender wender requested a review from ataideverton November 5, 2024 22:00
ataideverton
ataideverton previously approved these changes Nov 11, 2024
@ataideverton ataideverton force-pushed the bugfix/FSEUS-731-autocomplete-in-french branch from 3978aa1 to 65a6c17 Compare November 12, 2024 12:44
@ataideverton ataideverton merged commit 2756f6e into master Nov 12, 2024
14 of 15 checks passed
@ataideverton ataideverton deleted the bugfix/FSEUS-731-autocomplete-in-french branch November 12, 2024 12:48
Copy link

vtex-io-ci-cd bot commented Nov 12, 2024

Your PR has been merged! App is being published. 🚀
Version 3.16.1-beta.0 → 3.16.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants