Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [quick order] adjust validation of skus and show better status #167

Merged

Conversation

Josmar-jr
Copy link
Contributor

@Josmar-jr Josmar-jr commented Aug 14, 2024

What does this PR do? *

This PR includes the SKU validate fix, now it's possible to show the feedback reason error about the SKUs codes input at autocomplete and adjust style of the ReviewBlock component

How to test it? *

navigate to the page [workspace]/quickorder and enter with SKU code at autocomplete

Describe alternatives you've considered, if any. *

Screen Recording 2024-08-14 at 10.15.56.zip
Screenshot 2024-08-19 at 11 20 29

Related to / Depends on *

Copy link

vtex-io-ci-cd bot commented Aug 14, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

github-actions bot commented Aug 14, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 38, PR deletions = 33

Generated by 🚫 dangerJS against fe5d85b

Copy link

@enzomerca enzomerca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the Changelog? Thanks!

@enzomerca enzomerca requested a review from a team August 14, 2024 13:36
react/typings/vtex.styleguide.d.ts Outdated Show resolved Hide resolved
react/components/ReviewBlock.tsx Show resolved Hide resolved
react/components/ReviewBlock.tsx Outdated Show resolved Hide resolved
@ataideverton ataideverton merged commit 1685f43 into vtex-apps:master Aug 20, 2024
17 of 19 checks passed
Copy link

vtex-io-ci-cd bot commented Aug 20, 2024

Your PR has been merged! App is being published. 🚀
Version 3.15.4 → 3.15.5

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants