-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix to show product name on autocomplete options #166
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
|
|
}) | ||
.map((item: any) => { | ||
return { | ||
value: item.productName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any need to change the value too? It's not just the label? Having the value as a long string with special characters might not be the best thing
What does this PR do? *
This PR modifies the list of autocomplete options to display the product name rather than the product SKU name.
How to test it? *
In 'One by One' mode, type the name of a product, and a list of related products will appear instead of a list of related SKUs.