Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One by one. Quantity input [Fix: Mobile behavior] #156

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ivanlopezluna
Copy link

@ivanlopezluna ivanlopezluna commented Jul 23, 2023

What does this PR do? *

Fix poor behaviour on mobile when user needs to change item quantity.

It's not intuitive to change the value of the input since it cannot be empty, if the user wants to change the value from "1" to any other number, he must first put the desired amount and then he must remove the number "1".

How to test it? *

Before:

Workspace

Screenrecorder_20230723_113950.mp4

After:

Workspace

Screenrecorder_20230723_114200.mp4

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Jul 23, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@ivanlopezluna ivanlopezluna changed the title Fix/onebyonequantity One by one. Quantity input [Fix: Mobile behavior] Jul 23, 2023
@ivanlopezluna ivanlopezluna force-pushed the fix/onebyonequantity branch from 1c527c3 to 0a62108 Compare July 23, 2023 18:28
@ivanlopezluna
Copy link
Author

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)
  • Minor (backwards-compatible functionality)
  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@ivanlopezluna
Copy link
Author

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant