-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rootPath
handling in useSession
#375
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good to me overall! Just left a comment for us to discuss first.
Co-authored-by: Filipe W. Lima <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now!
Let me just undo the change in manifest.json
to get ready to merge and deploy this.
About the checks:
With all that said, I'm going ahead to merge and deploy this. |
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Sessions APIs request didn't consider the
rootPath
when building the URL, then the requests return an error 404.How to test it?
It should be tested in public domains because there's no
rootPath
in "myvtex", it's a CDN routing thing. I created two workspaces with Store Theme to ease the visualization.With my improvement
Without my improvement
The page should be scrolled to the first shelf because there are other Sessions requests from another component.
Screenshots or example usage:
Improved
Not improved
Ensure the caller
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 🔗
![](put .gif link here - can be found under "advanced" on giphy)