Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rootPath handling in useSession #375

Merged
merged 5 commits into from
Jun 22, 2023

Conversation

brunorodmoreira
Copy link
Contributor

What problem is this solving?

Sessions APIs request didn't consider the rootPath when building the URL, then the requests return an error 404.

How to test it?

It should be tested in public domains because there's no rootPath in "myvtex", it's a CDN routing thing. I created two workspaces with Store Theme to ease the visualization.

With my improvement
Without my improvement

The page should be scrolled to the first shelf because there are other Sessions requests from another component.

Screenshots or example usage:

  • Improved
    image

  • Not improved
    image

  • Ensure the caller
    image

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@brunorodmoreira brunorodmoreira requested a review from a team as a code owner May 5, 2023 20:14
@brunorodmoreira brunorodmoreira requested review from icazevedo and lariciamota and removed request for a team May 5, 2023 20:14
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented May 5, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good to me overall! Just left a comment for us to discuss first.

react/hooks/useSession.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

Let me just undo the change in manifest.json to get ready to merge and deploy this.

manifest.json Outdated Show resolved Hide resolved
@filipewl
Copy link
Contributor

About the checks:

CleanShot 2023-06-22 at 14 19 30


With all that said, I'm going ahead to merge and deploy this.

@filipewl filipewl merged commit 132aebb into master Jun 22, 2023
@filipewl filipewl deleted the fix/add-root-path-to-use-session branch June 22, 2023 18:13
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jun 22, 2023

Your PR has been merged! App is being published. 🚀
Version 2.83.1 → 2.83.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants