Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Czech country shortcode fix #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Git-the-Sanz
Copy link
Contributor

@Git-the-Sanz Git-the-Sanz commented Nov 30, 2022

This PR fixes the Google autocomplete feature for CZECH republic clients

WORKSPACE

Previous commit changed tooling that introduced NPM dependency conflicts. I updated the dependencies to be able to continue. We require advice on how to proceed.

#changingTooling

@Git-the-Sanz Git-the-Sanz added the bug Something isn't working label Nov 30, 2022
@Git-the-Sanz Git-the-Sanz self-assigned this Nov 30, 2022
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Nov 30, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@github-actions
Copy link

Fails
🚫

This PR will change tooling [:bulb: add #changingTooling on your description as ack to pass]

Warnings
⚠️

Looks like this PR is too large [:bulb: smaller PRs are easy to review and approve]

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 26143, PR deletions = 8017

Generated by 🚫 dangerJS against 671fe3b

@@ -4656,59 +4656,59 @@ module.exports._cities = [
regions: [
{
name: 'Hlavní město Praha',
shortCode: 'PR',
shortCode: 'Hlavní město Praha',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the values being returned from the geolocation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants