Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout config to reduce timeout errors in large carts #196

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Mecrano
Copy link

@Mecrano Mecrano commented Apr 25, 2024

What problem is this solving?

According to the official VTEX documentation on the AddToCart and UpdateItem, the official timeout is 45 seconds, however customers get multiple timeout errors at 30 seconds.

It is updated according to the documentation

Captura de pantalla 2024-04-25 a la(s) 5 05 08 p  m Captura de pantalla 2024-04-25 a la(s) 5 06 00 p  m

How should this be manually tested?

Create multiple promotional price tables and a shopping cart with many items (here we cannot point a clear number, such as 50 or 100, it depends on the promotions)

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Jira story (if applicable).
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Type of changes

✔️ Type of Change
✔️ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

Notes

Related KI

@Mecrano Mecrano self-assigned this Apr 25, 2024
@Mecrano Mecrano requested a review from a team as a code owner April 25, 2024 22:07
Copy link

vtex-io-ci-cd bot commented Apr 25, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Apr 25, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant