Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set viewedByCustomer is false, where is null #54

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

pabloppupulin
Copy link
Contributor

@pabloppupulin pabloppupulin commented Oct 29, 2024

This PR ensures that the viewedByCustomer property is always a boolean (true or false). This change prevents potential issues caused by null or undefined values.

Changes
Updated the assignment of viewedByCustomer to use double negation (!!) to ensure it is always a boolean.

Copy link

vtex-io-ci-cd bot commented Oct 29, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 29, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Oct 29, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 9, PR deletions = 2

Generated by 🚫 dangerJS against 8cb2ab9

@enzomerca enzomerca requested a review from a team October 29, 2024 13:08
Copy link

@pabloppupulin pabloppupulin merged commit 5d673bf into master Oct 30, 2024
15 checks passed
@pabloppupulin pabloppupulin deleted the fix/B2BTEAM-1932 branch October 30, 2024 16:29
Copy link

vtex-io-ci-cd bot commented Oct 30, 2024

Your PR has been merged! App is being published. 🚀
Version 2.6.2 → 2.6.3

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants