Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add warning topbar when inactive organization #179

Merged

Conversation

Josmar-jr
Copy link
Contributor

What problem is this solving?

Allow customization of content and colors by the merchant via storeframework. Add information right after login with customizable message via storeframework

How to test it?

Run the b2b-organizations and this repo - Run the vtex-apps/b2b-organizations-graphql#182 - Run the b2b-theme

  1. Access https://josmarjr--b2bstore005.myvtex.com/admin/b2b-organizations/organizations/#/settings
  2. Uncheck "Aprovar automaticamente novas organizações"
  3. Change the color at color picker or/and insert a new message to show at topbar
  4. Save the changes
  5. Access the store and do the login with your account

[Workspace](Link goes here!)

Screenshots or example usage:

Screenshot 2024-10-17 at 17 28 54 Screenshot 2024-10-17 at 17 27 59

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

Copy link

vtex-io-ci-cd bot commented Oct 17, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@@ -259,6 +259,11 @@
"admin/b2b-organizations.user-details.placeholder-costCenter": "Selecciona un centro de costos",
"admin/b2b-organizations.user-details.placeholder-role": "Selecciona un rol",
"admin/b2b-organizations.user-details.role": "Rol",
"admin/b2b-organizations.warning-topbar-inative-org.form.title": "Topbar customization",
"admin/b2b-organizations.warning-topbar-inative-org.form.help-text": "Customize the message and color of the top bar notifications that are displayed when the organization is disabled",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to get these messages translated?

@ataideverton ataideverton force-pushed the feat/add-warning-topbar-inactive-org branch from dc52611 to 2231a50 Compare December 9, 2024 12:08
Copy link

github-actions bot commented Dec 9, 2024

Warnings
⚠️

Looks like this PR is too large [:bulb: smaller PRs are easy to review and approve]

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 407, PR deletions = 46

Generated by 🚫 dangerJS against 2231a50

Copy link

sonarqubecloud bot commented Dec 9, 2024

@ataideverton ataideverton merged commit 87fdb8b into vtex-apps:master Dec 9, 2024
20 of 21 checks passed
Copy link

vtex-io-ci-cd bot commented Dec 9, 2024

Your PR has been merged! App is being published. 🚀
Version 1.37.3 → 1.38.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants