Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: its possible show more organization options according to the search #161

Conversation

Josmar-jr
Copy link
Contributor

What problem is this solving?

Before, listing more than 30 organizations was impossible, and the search functionality didn't work.

How to test it?

Log in to your admin account -> Log in to Fernando's store account (present in the task description) -> Go to the organization selection dropdown

Workspace

Screenshots or example usage:

Screen Recording 2024-06-13 at 12.10.15.zip
Screenshot 2024-06-13 at 12 49 35
Screenshot 2024-06-13 at 12 50 00

Describe alternatives you've considered, if any.

If possible list more organization options according to the search

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

Copy link

vtex-io-ci-cd bot commented Jun 13, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jun 13, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link
Contributor

@ataideverton ataideverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks ok and the tests are successful, just add the changelog entry and we can go ahead and merge it

Copy link

github-actions bot commented Jun 20, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 74, PR deletions = 60

Generated by 🚫 dangerJS against 69047e0

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
24.9% Duplication on New Code (required ≤ 15%)

See analysis details on SonarCloud

@ataideverton ataideverton merged commit 1099a4b into vtex-apps:master Jun 20, 2024
17 of 20 checks passed
Copy link

vtex-io-ci-cd bot commented Jun 20, 2024

Your PR has been merged! App is being published. 🚀
Version 1.31.8 → 1.31.9

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants