Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save edit, remove and add address data at organization #158

Merged
merged 3 commits into from
May 28, 2024

Conversation

Josmar-jr
Copy link
Contributor

What problem is this solving?

Previously it was not possible to save, edit and delete a new cost center address by confirming the addition in the modal

How to test it?

Log in to your store account, access the "my organization" page, enter a registered cost center and try to add or edit or delete an address.

[Workspace](https://josmar--b2bstore005.myvtex.com/account#/cost-center/cc-org-test-3

Screenshots or example usage:

Screen Recording 2024-05-20 at 10.09.27.zip

Screenshot 2024-05-20 at 10 12 39 Screenshot 2024-05-20 at 10 13 00 Screenshot 2024-05-20 at 10 13 06

Describe alternatives you've considered, if any.

It is now possible for the user to save an address to the cost center immediately after adding, editing and deleting

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

Copy link

vtex-io-ci-cd bot commented May 20, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@enzomerca enzomerca self-requested a review May 20, 2024 16:20
@casvtex casvtex requested a review from ArthurTriis1 May 21, 2024 12:27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArthurTriis1 Updated CHANGELOG

@ataideverton ataideverton merged commit c17bb9e into vtex-apps:master May 28, 2024
1 check failed
Copy link

vtex-io-ci-cd bot commented May 28, 2024

Your PR has been merged! App is being published. 🚀
Version 1.31.4 → 1.31.5

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants