Fix: collections pagination and other admin UX improvements #156
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
|
| !collectionsData?.collections?.items?.length || | ||
| collectionOptions.length | ||
| ) { | ||
| if (!collectionsData?.collections?.items?.length) { |
There was a problem hiding this comment.
question: could you explain why this line was changed? Why the check on collectionOptions.lenght was removed?
There was a problem hiding this comment.
The effect of this check is that it's impossible to advance to the next page of available collections. The code sees that collectionOptions already has length (the first page of results) and therefore skips setting the second page of results to state.
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Solves the problem where the collections tab of the admin organization details page does not allow pagination through the available collections (although the
##-## of ##text would change, the actual list of collections would never change). Also solves the problem where the initial collections query did not set any pageSize variable, resulting in only 20 records being returned. Also removes the option to show 100 collections per page, as the API allows a maximum of 50 to be returned at once.This PR also adds loading indicators to the admin organization details page, in the following tabs: cost centers, collections, payment terms, price tables, and sellers.
How to test it?
New version linked here: https://arthur--cosmorentals.myvtex.com/admin/b2b-organizations/organizations/7f7780af-dbfe-11ee-8452-0ecf4a7e9b55/#/collections
Note that you can successfully paginate through the available collections.