Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SVG animations #39

Merged
merged 16 commits into from
Oct 30, 2024
Merged

Conversation

Trombach
Copy link
Contributor

@Trombach Trombach commented Oct 27, 2024

Description

Implementation PR: vtbag/element-crossing#5

Adds an animated SVG image to test and demonstrate the new svg-anim expression

Todo:

  • make tests actually useful (not sure how since it's difficult to compare the animation times as they depend a bit on when playwright actually runs the code)
  • amend docs with info about abbreviated form, once decided

Copy link
Contributor

@martrapp martrapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next to the vanilla demo there is also a plain and a over-the-top demo that we should update accordingly by adding the animated SVG.
/crossing/over-the-top/1/
/crossing/plain/1/

@Trombach
Copy link
Contributor Author

Next to the vanilla demo there is also a plain and a over-the-top demo that we should update accordingly by adding the animated SVG. /crossing/over-the-top/1/ /crossing/plain/1/

Thanks, I missed that. I will add this and also make the required changes once we've agreed on the final implementation for this feature.

@Trombach Trombach requested a review from martrapp October 30, 2024 14:47
@martrapp
Copy link
Contributor

Love it! I'm very happy about this contribution! Thank you very much, Lukas!

@martrapp martrapp merged commit 05fa5c4 into vtbag:main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants