Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing deletion protection labels for users and grants #117

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

TheBigLee
Copy link
Member

@TheBigLee TheBigLee commented Nov 13, 2024

Summary

This PR adds the labels for the deletionProtection to the composite for the database user.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update the documentation.
  • Update tests.
  • Link this PR to related issues.

@TheBigLee TheBigLee requested a review from zugao November 13, 2024 18:18
@TheBigLee TheBigLee added the bug Something isn't working label Nov 13, 2024
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to cleanup

pkg/crossplane/service_mariadb_database.go Outdated Show resolved Hide resolved
pkg/crossplane/service_mariadb_database.go Outdated Show resolved Hide resolved
pkg/crossplane/service_mariadb_database.go Outdated Show resolved Hide resolved
@TheBigLee TheBigLee merged commit b1149e9 into master Nov 13, 2024
4 checks passed
@TheBigLee TheBigLee deleted the fix/del_prot_labels branch November 13, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants