forked from overhangio/tutor
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutor upgrade pull request #1
Open
nikhilkanta
wants to merge
1,086
commits into
vrook-co:master
Choose a base branch
from
overhangio:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
force-pushed
the
master
branch
3 times, most recently
from
May 17, 2021 19:30
0195e50
to
5658b46
Compare
regisb
force-pushed
the
master
branch
2 times, most recently
from
June 8, 2021 21:29
3fcce5d
to
ceddc11
Compare
regisb
force-pushed
the
master
branch
2 times, most recently
from
July 5, 2021 08:26
b00bed0
to
4f8f0fe
Compare
regisb
force-pushed
the
master
branch
3 times, most recently
from
March 24, 2022 08:44
e6c4fdf
to
43c5177
Compare
regisb
force-pushed
the
master
branch
2 times, most recently
from
October 26, 2022 10:28
89165ae
to
7541433
Compare
This is a follow-up fix to #819, where the corresponding change was added to the mysqld invocation in the "tutor local" (that is, docker-compose) deployment method, but omitted from its "tutor k8s" equivalent.
Now that sphinx_rtd support docutils>=0.19 we can drop that max version requirement. But we need to limit sphinx max version because they removed python 3.8 support before EOL.
Type tests were broken following the upgrade of click. We take the opportunity to simplify the TutorCli implementation.
Pound keys were interpreted as comments. This is annoying when we want to parse html color codes, such as in: $ tutor config save --set "INDIGO_PRIMARY_COLOR=#225522" $ tutor config printvalue INDIGO_PRIMARY_COLOR null Close #866.
The warning message printed during `tutor local upgrade` was incorrectly indented.
This is to address a few vulnerabilities in these libraries: https://github.com/overhangio/tutor/security/dependabot/54 https://github.com/overhangio/tutor/security/dependabot/53 https://github.com/overhangio/tutor/security/dependabot/48 https://github.com/overhangio/tutor/security/dependabot/46 https://github.com/overhangio/tutor/security/dependabot/52 https://github.com/overhangio/tutor/security/dependabot/51 https://github.com/overhangio/tutor/security/dependabot/49 https://github.com/overhangio/tutor/security/dependabot/47 https://github.com/overhangio/tutor/security/dependabot/50
Currently, we are asking devs to set this env var manually before they run tests. We may as well save them some keystrokes by setting it in the dev image programmatically.
This will add a `-c` / `--clean` flag to the save command and ensure that the env directory is deleted if it exists. Close #967
I found myself in a situation where I wasn't sure if a patch was correctly added by the Indigo plugin. To troubleshoot that issue, I wanted to print that rendered patch. I thought it would make a nice addition to the CLI.
In development, edx-platform runs with CELERY_ALWAYS_EAGER=True, which means that lms-worker and cms-worker never catch celery tasks! This change was heavily inspired by: #1041
Nope, we are not on Twitter (or X). And the youtube channel was renamed.
Before this, building organizations with longer URLs failed since the name field inside Site model has a max_length=50 Close #1144
* fix: upgrade MySQL from 5.7 to 8.1 first and then to 8.4 This is required when upgrading from Tutor v15 to v18 directly MySQL does not allow direct upgrades from v5.7 to v8.4 * fix: run MySQL 8.1 as a separate container during upgrade from Olive to Redwood (#1140) We do this because MySQL 8.1 does not have the --mysql-native-password option We have this option turned on for backward compatibility
The introduction of the `-c/--clean` option caused the deletion prompt to be displayed for every call to `tutor config save --interactive`. This is not the desired behaviour, as decided here: #1086 (comment) With this change, the prompt is only displayed when running: `tutor config save --interactive --clean`. The environment is still deleted on `tutor config save --clean`, but without prompt. We refactored the code with hooks, which simplifies the signature of the interactive prompt function.
Without this change, when building images with --cache-to-registry, BuildKit uses a proprietary cache artifact format, which breaks when using third-party registries such as Harbor or ECR. By adding the image-manifest=true option, BuildKit uses an OCI-compliant cache artifact format that should be compatible with all registries. This option requires BuildKit 0.12 or later (check with "docker buildx ls"). See goharbor/harbor#18941 and moby/buildkit#2251 for background information. Co-authored-by: Andrés González <[email protected]> Fixes #1118.
We take the opportunity to drop the constraint on docutils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tutor to newer version.
@varunramesh26 @akki2825 @Jashwanth-Gowda-R