Skip to content

Commit

Permalink
feat: better object creation in "k8s start"
Browse files Browse the repository at this point in the history
When running "tutor k8s start", it's unnecessary to attempt to create volumes
and namespace multiple times.
  • Loading branch information
regisb committed Jun 8, 2021
1 parent 900572f commit 9b6b770
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Note: Breaking changes between versions are indicated by "💥".

## Unreleased

- [Improvement] Better Kubernetes object creation.

## v11.3.0 (2021-05-18)

- 💥[Security] Disable python-evaluated input by default as we don't run codejail.
Expand Down
3 changes: 1 addition & 2 deletions tutor/commands/k8s.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,7 @@ def start(context: Context) -> None:
"--kustomize",
tutor_env.pathjoin(context.root),
"--selector",
# Here use `notin (job, xxx)` when there are other components to ignore
"app.kubernetes.io/component!=job",
"app.kubernetes.io/component notin (job,volume,namespace)",
)


Expand Down

0 comments on commit 9b6b770

Please sign in to comment.