Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y documentation updates december 23 #819

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

danielck
Copy link
Contributor

Description

  • Small updates and additions to the top-level Accessibility document. Updated target standard from WCAG 2.1 to 2.2 and added new checklist items for new criteria. Should have very little impact on current components.
  • Accessibility notes added to individual component documentation

Motivation and Context

  • The top-level documentation will not necessarily be read when researching the docs for an individual component, so it is important to have accessibility-related gotchas or outstanding issues listed visibly in the right context.

Release notes

  • Updates and additions to the top-level Accessibility document. Updated target standard from WCAG 2.1 to 2.2 and added new checklist items for new criteria.
  • Accessibility notes added to individual component documentation

Copy link
Collaborator

@riitasointi riitasointi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good ideas overall.

I would change the wording on the component pages slightly. Now we just basically repeat the sentences from the top-level accessibility page. I don't think a developer gets much out of them this way.

Example: On the TextInput page. "Success/error states are not distinguishable without colour." What? Why? Why should I care?

Maybe we should put something like "Success/error states (input borders) are currently not distinguishable without color. In addition to status, use a descriptive statusText to indicate the input's status"

@@ -1,5 +1,9 @@
The `<Breadcrumb>` component is used to let the user know their current location in a web service. It is rendered as an HTML `nav` element.

### Accessibility Notes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Accessibility Notes
### Accessibility notes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of these headings the "examples" section looks like it belongs to the accessibility notes, which is quite misleading.

@@ -2,6 +2,10 @@

The component's width should match the preferred length of the user input.

### Accessibility Notes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Accessibility Notes
### Accessibility notes

@@ -1,5 +1,9 @@
The `<Textarea>` component is suitable for longer user inputs.

### Accessibility Notes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Accessibility Notes
### Accessibility notes

@LJKaski
Copy link
Collaborator

LJKaski commented Jan 2, 2024

What do you consider the main benefit of having the accessibility statement related issues on the component pages in addition to the accessibility page? I'm not sure if I would give them such a center stage as in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants