Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIKA-584: remove twitter feed and cookieconsent #423

Merged
merged 3 commits into from
Feb 6, 2024
Merged

LIKA-584: remove twitter feed and cookieconsent #423

merged 3 commits into from
Feb 6, 2024

Conversation

bzar
Copy link
Contributor

@bzar bzar commented Feb 5, 2024

Description

  • Remove twitter feed from front page, change layout to accomodate.
  • Remove cookieconsent.

Jira ticket reference: LIKA-584

What has changed:

  • Changed templates
  • Deleted cookieconsent and references to it
  • Updated translations to remove cookieconsent references

Checklist

  • Contains schema changes.
  • Schema changes require migration of existing data.
  • Contains migration script for existing data.
  • Changes should be covered by tests.
  • Changes are covered by tests.

Does this have a design impact ?

  • Yes
  • No

Just a wider announcements component.

Zharktas
Zharktas requested changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@Zharktas Zharktas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ckanext/ckanext-apicatalog/ckanext/apicatalog/templates/home/snippets/twitter.html could be deleted all together, otherwise seems fine

@bzar bzar merged commit 4afd582 into master Feb 6, 2024
6 checks passed
@bzar bzar deleted the LIKA-584_remove-twitter-feed branch February 6, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zharktas Zharktas Zharktas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzar @Zharktas