Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added File Upload Capability and Loading logic to confirmation screen #55

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

mrzengel
Copy link
Collaborator

No description provided.

@garciagenrique
Copy link
Member

Hello @mrzengel

Thanks a lot for the PR.
It looks fine. I did a test with Sandbox and was correctly upload as a draft.

I would have two suggestions:

  • I found myself blocked in the moment that I clicked on Add Creator but then I realised that I didn't want to add one. Could you please implement the possibility of removing a creator field, please ?
  • Second, when you "submit" a record, the only message that a user receives is Submission Successful! Your information has been successfully submitted.. Could you please add a sub message clarifying that the records was NOT published yet, and that user would need to go to the zenodo record page to click on publish, please ? It would be amazing if you could add a link directly to the draft publication so that users don't need to go to zenodo -> login -> click on my dash boards --> click on upload. Not sure how easy this would be, as you cannot fetch the record id until it's uploaded at least as a draft. Let me know how feasible do you think it is.
    • As far as I remember, I think that the publish button was postponed to a second interaction. Could you please remind me this ?

Thanks in advance !!!

@garciagenrique
Copy link
Member

@Soap2G could you give a try to the extension too, please ?
Thanks !

Copy link
Member

@garciagenrique garciagenrique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants