-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix known vulnerabilities found by npm audit
#1083
Conversation
3 similar comments
@jedrivisser looks like something in the typescript coverage broke. I'm only seeing index.js being covered now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the typescript coverage
nyc 14 now requires you to state all extensions you want scanned that is not see: https://github.com/istanbuljs/nyc/blob/master/CHANGELOG.md#breaking-changes |
FYI I checked the coverage before and after, there are some changes, but ot looks like it ran correctly and includes all the files. $ npm install [email protected] && npm run cover
--------------------------|----------|----------|----------|----------|-------------------|
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
--------------------------|----------|----------|----------|----------|-------------------|
All files | 93.76 | 92.12 | 95.02 | 93.38 | |
node-soap | 100 | 100 | 100 | 100 | |
index.js | 100 | 100 | 100 | 100 | |
node-soap/src | 92.68 | 88.12 | 96.52 | 92.36 | |
client.ts | 95.56 | 92.94 | 91.89 | 95.48 |... 59,372,377,429 |
http.ts | 90 | 88.46 | 88.89 | 89.47 |... 64,168,170,171 |
nscontext.ts | 85.48 | 64.71 | 100 | 85.25 |... 86,138,161,229 |
server.ts | 90.54 | 91.67 | 100 | 90.19 |... 22,458,492,498 |
soap.ts | 97.1 | 83.33 | 100 | 96.49 | 51,52 |
utils.ts | 100 | 62.5 | 100 | 100 | 8,9,10 |
node-soap/src/security | 97.11 | 88.89 | 92.5 | 96.99 | |
BasicAuthSecurity.ts | 92.86 | 50 | 80 | 92.31 | 22 |
BearerSecurity.ts | 92.31 | 100 | 80 | 91.67 | 20 |
ClientSSLSecurity.ts | 100 | 100 | 100 | 100 | |
ClientSSLSecurityPFX.ts | 100 | 100 | 100 | 100 | |
NTLMSecurity.ts | 92.31 | 100 | 80 | 91.67 | 29 |
WSSecurity.ts | 93.94 | 91.67 | 100 | 93.75 | 53,97 |
WSSecurityCert.ts | 100 | 87.5 | 100 | 100 | 71 |
index.ts | 100 | 100 | 100 | 100 | |
node-soap/src/wsdl | 93.87 | 94.25 | 94.44 | 93.41 | |
elements.ts | 96.12 | 94.42 | 97.4 | 95.27 |... 6,908,953,1070 |
index.ts | 91.53 | 94.12 | 89.8 | 91.81 |... 1337,1375,1395 |
--------------------------|----------|----------|----------|----------|-------------------| and then $ npm install [email protected] && npm run cover
--------------------------|----------|----------|----------|----------|-------------------|
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
--------------------------|----------|----------|----------|----------|-------------------|
All files | 94.61 | 89.25 | 95.02 | 94.46 | |
node-soap | 100 | 100 | 100 | 100 | |
index.js | 100 | 100 | 100 | 100 | |
node-soap/src | 93.65 | 84.6 | 96.52 | 93.51 | |
client.ts | 96.35 | 90.3 | 91.89 | 96.63 |... 55,359,377,429 |
http.ts | 89.19 | 79.55 | 88.89 | 88.73 |... 67,168,170,171 |
nscontext.ts | 88.75 | 78.26 | 100 | 88.61 |... 86,138,161,229 |
server.ts | 92.1 | 82.32 | 100 | 91.84 |... 22,458,492,498 |
soap.ts | 97.44 | 87.5 | 100 | 96.97 | 51,52 |
utils.ts | 100 | 78.57 | 100 | 100 | 8,9,10 |
node-soap/src/security | 97.56 | 94 | 92.5 | 97.45 | |
BasicAuthSecurity.ts | 92.86 | 50 | 80 | 92.31 | 22 |
BearerSecurity.ts | 92.31 | 100 | 80 | 91.67 | 20 |
ClientSSLSecurity.ts | 100 | 100 | 100 | 100 | |
ClientSSLSecurityPFX.ts | 100 | 100 | 100 | 100 | |
NTLMSecurity.ts | 92.86 | 100 | 80 | 92.31 | 29 |
WSSecurity.ts | 95.24 | 90.48 | 100 | 95.12 | 53,97 |
WSSecurityCert.ts | 100 | 93.75 | 100 | 100 | 71 |
index.ts | 100 | 100 | 100 | 100 | |
node-soap/src/wsdl | 94.73 | 91.06 | 94.44 | 94.57 | |
elements.ts | 96.62 | 92.64 | 97.4 | 96.06 |... 05,906,908,953 |
index.ts | 92.98 | 90.07 | 89.8 | 93.43 |... 1337,1375,1395 |
--------------------------|----------|----------|----------|----------|-------------------| |
FANTASTIC @jedrivisser !!!!! Thank you so much! |
Fix lodash security issues - severity high
https://www.npmjs.com/advisories/1065
Needs to be updated to version 4.17.12 or later.
Updated dev dependencies that have vulnerabilities according to
npm audit
as well