Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z3 intefacing fix #647

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Z3 intefacing fix #647

merged 3 commits into from
Jan 20, 2025

Conversation

joe-hauns
Copy link
Contributor

Bug fix in the translation of polymorphic vampire terms to monomorphic z3 terms.

Copy link
Contributor

@MichaelRawson MichaelRawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. What happens if we have something of still-polymorphic type, say nil : list(X)?

@MichaelRawson MichaelRawson merged commit f55788f into master Jan 20, 2025
1 check passed
@MichaelRawson MichaelRawson deleted the z3-intefacing-fix branch January 20, 2025 09:17
@joe-hauns
Copy link
Contributor Author

good question.. I think it shoud be alright, as we're just abstracting making list(X) and list(int) unrelated, not?
But the original code is from you right? haha
I just updated what were doing for results to match what we're doing for arguments.

@MichaelRawson
Copy link
Contributor

Indeed. 😇 IIRC that path wasn't handled in the code I replaced, so I didn't handle it either - it never seemed to actually happen, somehow it gets trapped earlier in the Vampire-to-Z3 pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants