Fix OrderingComparator for non-specialized orderings #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etBranch; set empty TermPartialOrdering in default implementation of OrderingComparator::processTermNode
quickbeam123
approved these changes
Jan 15, 2025
|
Do you want me, @mezpusz , to run any checks? (The change itself is below my resolution in this part of the codebase ;)) |
I will run some debug checks, I don't think performance tests are needed. |
MichaelRawson
approved these changes
Jan 15, 2025
MichaelRawson
deleted the
fix-ordering-comparator-for-non-specialized-orderings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @joe-hauns pointed out, calling
OrderingComparatorfor a term ordering that does not specialize this class orcompareUnidirectionalresults in some assertion violations. This PR attempts at rooting these out.