feat: sdl3 #348
Open
feat: sdl3 #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If somebody could explain me why a Debug build fails on the link phase but the Release build succeeds that would be great. |
oops
|
@toxieainc should I care about the |
|
@toxieainc What is the expected way this should be packaged as SDL3 should be provided or statically compiled and rpath adjusted? With the current setup on macOS for example: |
|
For my part this is ready for review. |
Don't know, at least there is |
|
As for how SDL is used, that is something up to @jsm174 to decide, please. |
|
for a standalone command line app like this, I almost think a static lib would be better as it doesn't force the user to have the right version installed or you having to provide it etc. In vpx standalone for the mac, I know we do include dylibs, however it's a macos app bundle, so we can package all our dylibs in the frameworks folder. If you decide to use the shared lib, than you can play around with the rpath options in cmake, see here. btw, you can also alter rpaths after the build using |
Oh, looks like that has changed, used to fail on some conflict in deb dependencies. Let me fix it then. |
|
Looks like the Also In how far is pinmame still getting upstream mame updates? |
If it's possible to create the mame_debugger versions with cmake cleaning up is probably a good idea. I used the makefiles for sdl tests and mame_debuger versions.
While looking into where to start with sdl3 for windows. I tried to understand why there is a unix src and a windows src side and why they are so different. Mame is now cpp and has a complete different structure now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ported the SDL code to SDL3. (continuation of #203)
Used the approach of building SDL3 in the project like is done on standalone / libdmdutil / libaltsound. SDL3 is currently not available in homebrew nor ubuntu apt repositories.
X11 is ancient tech that is going away.
xpinmameon linux now builds against SDL3 for graphics and sound.Some light crackling on the sound, probably something to do with pinmame not coming up with audio data in time? Had the same issue with coreaudio.
TODO
-scale 4for example)does the -md build still work and show the debug window, was this ever the case?(not in use for xpinmame)