chore: use String.format.

vpa1977 · Oct 8, 2024 · 1b23bce · 1b23bce
1 parent bd8e30f
commit 1b23bce
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/rockcraft/src/main/java/com/canonical/rockcraft/builder/RockCrafter.java b/rockcraft/src/main/java/com/canonical/rockcraft/builder/RockCrafter.java
@@ -133,18 +133,18 @@ private Map<String,Object> getImageProjectParts(List<String> images) {
         HashMap<String, Object> parts = new HashMap<String, Object>();
         int id = 0;
         for (String image : images) {
-            parts.put(settings.getGeneratorName() + "/rockcraft/dump"+id, getImageDumpPart(image));
+            parts.put(String.format("%s/rockcraft/dump%d",settings.getGeneratorName(), id), getImageDumpPart(image));
             ++id;
         }
-        parts.put(settings.getGeneratorName() + "/rockcraft/deps", getDepsPart());
+        parts.put(String.format("%s/rockcraft/deps", settings.getGeneratorName()) , getDepsPart());
         return parts;
     }
 
     private Map<String,Object> getImageDumpPart(String image) {
         Map<String,Object> part = new HashMap<String, Object>();
         part.put("source", ".");
         part.put("plugin", "nil");
-        part.put("override-build", "cp  --archive --link --no-dereference " + image + " /");
+        part.put("override-build", String.format("cp  --archive --link --no-dereference %s /", image));
         return part;
     }
 
@@ -164,7 +164,7 @@ public boolean accept(File file, String name) {
                 Map<String, Object> serviceDefinition = new HashMap<String, Object>();
                 serviceDefinition.put("override", "replace");
                 serviceDefinition.put("summary", serviceName);
-                serviceDefinition.put("command", "/" + relativeImage + "/bin/" + serviceName);
+                serviceDefinition.put("command", String.format("/%s/bin/%s", relativeImage, serviceName));
                 services.put(serviceName, serviceDefinition);
             }
         }