Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monthFormat default value #1408

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Fix monthFormat default value #1408

merged 4 commits into from
Sep 5, 2023

Conversation

takurinton
Copy link
Contributor

@takurinton takurinton commented Sep 4, 2023

#1398

i18n 対応した際に、カレンダー単体としての動作が壊れてしまったので修正。
具体的な対応内容は以下。

  • Calendar/CalendarRange の monthFormat prop に初期値がなくて dayjs の初期値が入っていたので修正。
  • Calendar/CalendarRange の weekList prop に初期値がなくて曜日が表示されてなかったので修正。

before
image

after

image

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2023

🦋 Changeset detected

Latest commit: 3d964bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ingred-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for ingred-ui ready!

Name Link
🔨 Latest commit 3d964bb
🔍 Latest deploy log https://app.netlify.com/sites/ingred-ui/deploys/64f66fb2a70b7000083c5807
😎 Deploy Preview https://deploy-preview-1408--ingred-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@takurinton takurinton requested a review from Yutan0423 September 5, 2023 00:04
Copy link
Contributor

@Yutan0423 Yutan0423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@takurinton takurinton merged commit c392ecd into master Sep 5, 2023
2 checks passed
@takurinton takurinton deleted the fix-calendar branch September 5, 2023 00:24
@FluctMember FluctMember mentioned this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants