Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "storybook v6 -> v7" #1257

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Revert "storybook v6 -> v7" #1257

merged 1 commit into from
Apr 25, 2023

Conversation

takurinton
Copy link
Contributor

Reverts #1214

DataTable コンポーネントで CustomCell をレンダリングすると固まるようになってしまったので一旦 revert します。
https://ingred-ui.netlify.app/?path=/story/components-data-display-datatable--custom-cell

デバッグの参考

https://cartaholdings.slack.com/archives/C02Q8F3FQBC/p1682399433577159

testEnv だと表示されるので storybook の問題かなあ
image

https://cartaholdings.slack.com/archives/C02Q8F3FQBC/p1682400028260519

コミット戻してやってみたけど、storybook v7 の問題ぽいな
image

@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for ingred-ui ready!

Name Link
🔨 Latest commit bfafaf3
🔍 Latest deploy log https://app.netlify.com/sites/ingred-ui/deploys/64477567e86c7b0008adfd50
😎 Deploy Preview https://deploy-preview-1257--ingred-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@takurinton
Copy link
Contributor Author

表示されるのでやはり storybook のアップデートの問題っぽい
https://deploy-preview-1257--ingred-ui.netlify.app/?path=/story/components-data-display-datatable--custom-cell

@takurinton takurinton merged commit 3457a95 into master Apr 25, 2023
@takurinton takurinton deleted the revert-1214-storybook-v7 branch April 25, 2023 06:44
takurinton added a commit that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants