storybook v6 -> v7 #1214
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "sourceType": "unambiguous", | ||
| "presets": [ | ||
| [ | ||
| "@babel/preset-env", | ||
| { | ||
| "targets": { | ||
| "chrome": 100 | ||
| } | ||
| } | ||
| ], | ||
| "@babel/preset-typescript", | ||
| "@babel/preset-react" | ||
| ], | ||
| "plugins": [ | ||
| [ | ||
| "@babel/plugin-proposal-class-properties", | ||
| { | ||
| "loose": true | ||
| } | ||
| ] | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,15 +67,17 @@ describe("{{ inputs.name | pascal }} component testing", () => { | |
|
|
||
| ```typescript | ||
| import * as React from "react"; | ||
| import { StoryObj } from "@storybook/react"; | ||
|
There was a problem hiding this comment. Storyは非推奨、v7化以降はオブジェクトで書く。 |
||
| import {{ inputs.name | pascal }}, { {{ inputs.name | pascal }}Props } from "./{{ inputs.name | pascal }}"; | ||
|
|
||
| export default { | ||
| title: "Components/〇〇/{{ inputs.name | pascal }}", | ||
| component: {{ inputs.name | pascal }}, | ||
| }; | ||
|
|
||
| export const Example: StoryObj<{{ inputs.name | pascal }}Props> = { | ||
| render: (args) => ( | ||
| <{{ inputs.name | pascal }} {...args} /> | ||
| ) | ||
| }; | ||
| ``` | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,26 +8,25 @@ module.exports = { | |
| "@storybook/addon-essentials", | ||
| "@storybook/addon-links", | ||
| "@storybook/addon-storysource", | ||
|
There was a problem hiding this comment. v7では使えなさそう そもそもPostCSS使いたくていれたものじゃなさそう |
||
| { | ||
| // MEMO: included in addon-essentials | ||
| name: "@storybook/addon-docs", | ||
| options: { | ||
| csfPluginOptions: { | ||
| injectStoryParameters: false, | ||
| }, | ||
|
Comment on lines
14
to
17
There was a problem hiding this comment. There was a problem hiding this comment. @takurinton |
||
| }, | ||
| }, | ||
| "@storybook/addon-mdx-gfm", | ||
| ], | ||
| features: { | ||
| babelModeV7: true, | ||
| }, | ||
| framework: { | ||
| name: "@storybook/react-webpack5", | ||
| options: {}, | ||
| }, | ||
| docs: { | ||
| autodocs: true, | ||
| }, | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| import * as React from "react"; | ||
| import { ThemeProvider, createTheme } from "../src/themes"; | ||
|
There was a problem hiding this comment. v7対応されなそう 必要か判断した上で、代替手段を要調査 |
||
|
|
||
| const theme = createTheme(); | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import { action } from "@storybook/addon-actions"; | ||
| import { ArgsTable, Description, Stories, Title } from "@storybook/addon-docs"; | ||
| import { StoryObj } from "@storybook/react"; | ||
| import React from "react"; | ||
| import ActionButton, { ActionButtonProps } from "./ActionButton"; | ||
|
|
||
|
|
@@ -14,7 +14,7 @@ export default { | |
| }, | ||
| parameters: { | ||
| docs: { | ||
| source: { language: "tsx" }, | ||
|
There was a problem hiding this comment.
|
||
| page: () => ( | ||
| <> | ||
| <Title /> | ||
|
|
@@ -27,16 +27,20 @@ export default { | |
| }, | ||
| }; | ||
|
|
||
| export const Primary: StoryObj<ActionButtonProps> = { | ||
| args: { | ||
| color: "primary", | ||
| }, | ||
| }; | ||
|
|
||
| export const Warning: StoryObj<ActionButtonProps> = { | ||
| args: { | ||
| color: "warning", | ||
| }, | ||
| }; | ||
|
|
||
| export const Disabled: StoryObj<ActionButtonProps> = { | ||
| args: { | ||
| disabled: true, | ||
| }, | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v7からは.babelrcを作ってそれを読むようになるっぽい
https://storybook.js.org/docs/react/configure/babel#v7-mode