Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Run unit tests parallel to RuboCop #140

Merged
merged 1 commit into from
Jun 28, 2024
Merged

CI: Run unit tests parallel to RuboCop #140

merged 1 commit into from
Jun 28, 2024

Conversation

bastelfreak
Copy link
Member

Previously we weren't depending on the rubocop job, which was a mistake.

@bastelfreak bastelfreak self-assigned this Jun 28, 2024
@bastelfreak
CI: mark CI as successfull when rubocop and unit tests pass
ec554fc 
Previously we weren't depending on the rubocop job, which was a mistake.
@bastelfreak bastelfreak merged commit 9b36592 into voxpupuli:master Jun 28, 2024
7 checks passed
@bastelfreak bastelfreak deleted the rubocop2 branch June 28, 2024 15:22
ekohl
ekohl reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with the description of this change. Previously the tests didn't even run if RuboCop failed. Now it runs RuboCop in parallel to the tests.

Given how cheap the tests in this repo are, that's probably a good thing but the description is misleading.

@ekohl ekohl changed the title CI: mark CI as successfull when rubocop and unit tests pass CI: Run unit tests parallel to RuboCop Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@sebastianrakel sebastianrakel sebastianrakel approved these changes

Assignees

@bastelfreak bastelfreak

Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @ekohl @sebastianrakel