Don't do nodejs::install when manage_package_repo is set to false.

[anordby]

Pull Request (PR) description

Do not call the nodejs::install when manage_package_repo is set to false.

This Pull Request (PR) fixes the following issues

When/if you like to write /root/.npmrc yourself, it will fail otherwise as nodejs module also does it:

Jul 17 10:10:25 no000010sresd0 puppet-agent[31736]: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: File[/root/.npmrc] is already declared at (file: /etc/puppetlabs/code/vcs/ops/ops_master/external-modules/nodejs/manifests/install.pp, line: 55); cannot redeclare (file: /etc/puppetlabs/code/vcs/devops/devops_master/modules/moller/manifests/modules/node.pp, line: 42) (file: /etc/puppetlabs/code/vcs/devops/devops_master/modules/moller/manifests/modules/node.pp, line: 42, column: 2) (file: /etc/puppetlabs/code/vcs/devops/devops_master/modules/moller/manifests/modules/mollerservice.pp, line: 85) on node no000010sresd0.moller.local

[anordby]

Can I have some action here @evgeni ?

[anordby]

Or @kenyon ?

[smortex]

Not a user of nodejs so maybe I am missing something obvious, but…

Indeed this break CI. The point of a nodejs module is to manage nodejs… Skipping the repository may be necessary for some users (in order to use a custom one I suppose) but skipping package installation and configuration does not make sense IMHO.

My guess is that your moller module should leverage the nodejs module to make it generate the configuration you expect.

[anordby]

I agree the checks should be fixed of course. Can have a look. But purpose of manage_package_repo should be to not manage repo or package? If package repo is not managed how can you install? Some of just want/wanted the npm provider. Did not get any feedback so far, that's why I did not do anything more.. @smortex

[evgeni]

If you just need the provider, you don't need to include the module at all as long as it's available in the environment.

[kenyon]

Agree with @smortex and @evgeni and IMHO we should close this. Maybe instead we could document in the README that the npm package provider can be used without including the npm class.

[evgeni]

Closing as invalid, feel free to reopen when you have more details.