Create grafana config directory #339
Conversation
Prior to this commit, attempting to created a provisioned datasource or dashboard would fail with the following: Could not set 'file' on ensure: No such file or directory - A directory component in /etc/grafana/provisioning/datasources/<datasource> does not exist or is a dangling symbolic link This commit ensure that archive installations create the directory with a default of /etc/grafana
| @@ -158,6 +158,7 @@ | |||
| String $docker_ports = '3000:3000', | |||
| String $data_dir = '/var/lib/grafana', | |||
| String $install_dir = '/usr/share/grafana', | |||
| String $config_dir = '/etc/grafana', | |||
There was a problem hiding this comment.
please use:
| String $config_dir = '/etc/grafana', | |
| Stdlib::Absolutepath $config_dir = '/etc/grafana', |
|
So this was part of work to add versions to archive installations in operational dashboards, but I'm realizing that it doesn't work and probably hasn't been for a while, at least on some platforms. On SLES 12 and 15 it claims to start the service but doesn't, and I assume it has something to do with how it's defined here. We'd also have to do something like we do with the systemd config file in ops dashboards so that we know the server is fully started. But since it's manually starting the service with the Should we just drop archive support in this module and ops dashboards? It looks like there's a package available for all major platforms, and using a repo or package is so much easier. |
|
is this still necessary? we merged PR #362 which creates the needed folder |
Prior to this commit, attempting to created a provisioned datasource or dashboard after installing from an archive source would fail with the following:
Could not set 'file' on ensure: No such file or directory - A directory component in /etc/grafana/provisioning/datasources/ does not exist or is a dangling symbolic link
This commit ensure that archive installations create the directory with a default of /etc/grafana