support RedHat-based distro 8 & 9 #240
Conversation
mcodenie
force-pushed
the
master
branch
4 times, most recently
from
42b60d1
to
4e92246
Compare
|
apology no RSpec test background on adding/modifying, supposedly will point the mirror for CentOS 8 from mirror.centos.org to vault.centos.org. For Rocky, Centos Stream, and AlmaLinux based on the changed repo. |
|
@smortex are there any open items for? I would be happy to have the posibility to use this module with RH8 in our environment. |
There was a problem hiding this comment.
Wow, old PR… This may still make sense but as a non-gluster user I can only give advice regarding the Puppet part.
@Kotty666, if interested in this and you know how to reliable check if repos are enabled or not, feel free to fill-in a new PR on top of this to adjust it.
| exec { 'Enabling Codeready-Builder repo': | ||
| command => 'dnf config-manager --set-enabled codeready-builder-for-rhel-8-x86_64-rpms', | ||
| path => ['/usr/bin', '/usr/sbin',], | ||
| unless => 'rpm -qa | grep -c python3-pyxattr', |
There was a problem hiding this comment.
Not a yum/dnf user, but that does not look like the right way to check if a given repository is enabled.
| exec { 'Enabling PowerTools repo': | ||
| command => 'dnf config-manager --set-enabled powertools', | ||
| path => ['/usr/bin', '/usr/sbin',], | ||
| unless => 'rpm -qa | grep -c python3-pyxattr', |
| '8' => 'centos.org/centos/8-stream', | ||
| '9' => 'stream.centos.org/SIGs/9-stream', | ||
| default => "centos.org/centos/${facts['os']['release']['major']}" |
There was a problem hiding this comment.
Style:
| '8' => 'centos.org/centos/8-stream', | |
| '9' => 'stream.centos.org/SIGs/9-stream', | |
| default => "centos.org/centos/${facts['os']['release']['major']}" | |
| '8' => 'centos.org/centos/8-stream', | |
| '9' => 'stream.centos.org/SIGs/9-stream', | |
| default => "centos.org/centos/${facts['os']['release']['major']}" |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues