Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including other names in the preer probe fact #125

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Including other names in the preer probe fact #125

wants to merge 3 commits into from

Conversation

netdata-be
Copy link

When having multiple interfaces on a gluster cluster.
It is now possible to probe each interface and facter will return the
other names as well.
Otherwise fater will probe each run

Fixes #124

Wouter D'Haeseleer added 3 commits June 29, 2017 13:14
Including other names in the preer probe fact
517703d 
When having multiple interfaces on a gluster cluster.
It is now possible to probe each interface and facter will return the
other names as well.
Otherwise fater will probe each run

Fixes voxpupuli#124
The peer name is not always the same as the FQDN, so use a more cleve…
c5ad8d1 
…r test
Strip the brick test, it would fail anyway if bricks are not in the p…
58c61fa 
…robe list
@glorpen glorpen mentioned this pull request Jul 19, 2017
Merged
@bastelfreak
Copy link
Member

Hi @netdata-be, thanks for the PR. Can you please rebase and take a look at the failing travis tests?

@vox-pupuli-tasks
Copy link

Dear @netdata-be, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @netdata-be, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

1 similar comment
@vox-pupuli-tasks
Copy link

Dear @netdata-be, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge-conflicts needs-rebase tests-fail
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"gluster peer probe" getting called on each puppet run
3 participants
@netdata-be @bastelfreak @dhoppe