add jdk17 option #241
Merged
add jdk17 option #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHoenscheid
force-pushed
the
jdk17_jvm_opts
branch
from
d74f510
to
ea760a2
Compare
|
Seems like operatingsystem_support in metadata is so outdated that there is no os'es to run acceptance/integration tests on. Do you have time to create another pr that add supported versions to metadata? |
SimonHoenscheid
force-pushed
the
jdk17_jvm_opts
branch
from
ea760a2
to
6aff288
Compare
h-haaks
reviewed
Aug 23, 2024
| <%- if scope.lookupvar('confluence::jvm_type') == 'openjdk-11' -%> | ||
| <%- if scope.lookupvar('confluence::jvm_type') == 'openjdk-17' -%> | ||
| CATALINA_OPTS="-XX:+ExplicitGCInvokesConcurrent ${CATALINA_OPTS}" | ||
| CATALINA_OPTS="-Xlog:gc*:file=$LOGBASEABS/logs/gc-%t.log:tags,time,uptime,level:filecount=5,filesize=2M ${CATALINA_OPTS}" |
There was a problem hiding this comment.
Update unit tests? I think there is some jdk specific tests already.
SimonHoenscheid
force-pushed
the
jdk17_jvm_opts
branch
from
0502224
to
d46a751
Compare
lbetz
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled over an issue with JDK17, which is documented here:
https://confluence.atlassian.com/confkb/unrecognized-jvm-gc-options-when-using-jdk-11-17-1002472841.html
This is just a quick fix. I am aware this module needs some love, so this is just the beginning