Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debian-11-arm64 support #330

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

yachub
Copy link
Contributor

@yachub yachub commented Sep 11, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (f47bca2) 0.73% compared to head (ec76c8b) 0.72%.

❗ Current head ec76c8b differs from pull request most recent head 368ce5a. Consider uploading reports for the commit 368ce5a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #330      +/-   ##
=========================================
- Coverage    0.73%   0.72%   -0.01%     
=========================================
  Files          15      15              
  Lines        1776    1787      +11     
=========================================
  Hits           13      13              
- Misses       1763    1774      +11     
Files Changed Coverage Δ
lib/beaker-hostgenerator/data.rb 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 192 to 194
abs: {
'template' => 'debian-11-arm64',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be redundant since it's generated by:

when /^(debian|ubuntu)/
os = Regexp.last_match(1)
base_template = node_info['ostype'].sub(os, "#{os}-")
arch = case node_info['bits']
when '64'
'x86_64'
when '32'
'i386'
when 'AARCH64'
'arm64'
when 'POWER'
base_template.sub!(/#{os}-(\d\d)/, "#{os}-\1.")
'power8'
else
raise "Unknown bits '#{node_info['bits']}' for '#{node_info['ostype']}'"
end

Copy link
Contributor Author

@yachub yachub Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I was a bit confused because the template key was missing from the generated fixtures, but specifying the abs hypervisor does indeed generate that key as expected.

Does that sound good? If so, I'll squash commits. Thanks

Comment on lines 195 to 197
vmpooler: {
'template' => 'debian-11-arm64',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps enhance this part to generate it:

when /^(debian|ubuntu)/
os = Regexp.last_match(1)
arch = case node_info['bits']
when '64'
'x86_64'
when '32'
'i386'
end
base_config['template'] ||= "#{node_info['ostype'].sub(os, "#{os}-")}-#{arch}" if arch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I don't think we need to use the vmpooler hypervisor moving forward.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also happy to drop vmpooler, or at least stop updating it.

@ekohl ekohl merged commit 403fd6e into voxpupuli:master Sep 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants