-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debian-11-arm64 support #330
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
=========================================
- Coverage 0.73% 0.72% -0.01%
=========================================
Files 15 15
Lines 1776 1787 +11
=========================================
Hits 13 13
- Misses 1763 1774 +11
☔ View full report in Codecov by Sentry. |
lib/beaker-hostgenerator/data.rb
Outdated
abs: { | ||
'template' => 'debian-11-arm64', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be redundant since it's generated by:
beaker-hostgenerator/lib/beaker-hostgenerator/hypervisor/abs.rb
Lines 30 to 45 in f47bca2
when /^(debian|ubuntu)/ | |
os = Regexp.last_match(1) | |
base_template = node_info['ostype'].sub(os, "#{os}-") | |
arch = case node_info['bits'] | |
when '64' | |
'x86_64' | |
when '32' | |
'i386' | |
when 'AARCH64' | |
'arm64' | |
when 'POWER' | |
base_template.sub!(/#{os}-(\d\d)/, "#{os}-\1.") | |
'power8' | |
else | |
raise "Unknown bits '#{node_info['bits']}' for '#{node_info['ostype']}'" | |
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, I was a bit confused because the template
key was missing from the generated fixtures, but specifying the abs
hypervisor does indeed generate that key as expected.
Does that sound good? If so, I'll squash commits. Thanks
lib/beaker-hostgenerator/data.rb
Outdated
vmpooler: { | ||
'template' => 'debian-11-arm64', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps enhance this part to generate it:
beaker-hostgenerator/lib/beaker-hostgenerator/hypervisor/vmpooler.rb
Lines 25 to 34 in f47bca2
when /^(debian|ubuntu)/ | |
os = Regexp.last_match(1) | |
arch = case node_info['bits'] | |
when '64' | |
'x86_64' | |
when '32' | |
'i386' | |
end | |
base_config['template'] ||= "#{node_info['ostype'].sub(os, "#{os}-")}-#{arch}" if arch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I don't think we need to use the vmpooler hypervisor moving forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also happy to drop vmpooler, or at least stop updating it.
No description provided.