Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RE-15206) Add ubuntu-2204-arm64 fixtures #328

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

yachub
Copy link
Contributor

@yachub yachub commented Sep 8, 2023

I'm not sure if this is needed since there was some data added in #248 and released in 1.14.0, but without any changes to data.rb, these were the fixtures generated with bundle exec rake generate:fixtures

Side note, it seems a bit odd that we don't set the template key for the ubuntu platforms here. This must be already be inserted by beaker-abs, but I haven't gone looking

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (da8ac9a) 0.73% compared to head (64c2228) 0.73%.

❗ Current head 64c2228 differs from pull request most recent head 63031c1. Consider uploading reports for the commit 63031c1 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #328   +/-   ##
======================================
  Coverage    0.73%   0.73%           
======================================
  Files          15      15           
  Lines        1765    1765           
======================================
  Hits           13      13           
  Misses       1752    1752           

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@ekohl
Copy link
Member

ekohl commented Sep 8, 2023

I'm not sure if this is needed since there was some data added in #248 and released in 1.14.0, but without any changes to data.rb, these were the fixtures generated with bundle exec rake generate:fixtures

It's a good question. As more logic is generated dynamically, testing it becomes more important. But just storing huge generated files doesn't guarantee it's correct.

Side note, it seems a bit odd that we don't set the template key for the ubuntu platforms here. This must be already be inserted by beaker-abs, but I haven't gone looking:

I've been working on moving away from a huge data.rb and instead push logic into specific hypervisors to generate data dynamically. So https://github.com/voxpupuli/beaker-hostgenerator/blob/master/lib/beaker-hostgenerator/hypervisor/abs.rb already does this.

@yachub yachub merged commit f47bca2 into voxpupuli:master Sep 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants