Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: Concert #1

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

New Adapter: Concert #1

wants to merge 48 commits into from

Conversation

BrettBlox
Copy link
Member

@BrettBlox BrettBlox commented Apr 22, 2024 •
edited
Loading

Documentation update PR here: voxmedia/prebid.github.io#3

@BrettBlox BrettBlox mentioned this pull request Apr 30, 2024
Merged
4 tasks
@BrettBlox BrettBlox marked this pull request as ready for review April 30, 2024 17:09
antoinfive
antoinfive approved these changes Apr 30, 2024
View reviewed changes
Copy link

@antoinfive antoinfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

walia
walia approved these changes May 1, 2024
View reviewed changes
Copy link

@walia walia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this!

BrettBlox added 26 commits May 2, 2024 09:21
@BrettBlox
adds empty files for concert adapter
f91e305
@BrettBlox
adds placeholder config options
d34e432
@BrettBlox
omits gvlVendorId from config
5aeb95f
@BrettBlox
removes dooh capability
b7a6fe3
@BrettBlox
removes native media types
7b5df75
@BrettBlox
adds placeholder concert support email - to be confirmed
33b8a4d
@BrettBlox
scaffolds out basic go adapter for concert
217570f
@BrettBlox
adds concert to adapter_builders and bidders lists
ad315c1
@BrettBlox
translates prebidjs bidder params to prebid server schema for concert…
6be2f7d 
… adapter
@BrettBlox
adds params struct file and updates adapter
1161540
@BrettBlox
extracts publisher id and forwards it in site object
b087828
@BrettBlox
runs format script
b1de33e
@BrettBlox
scaffolds test files
dffccd1
@BrettBlox
adds mock bid requests for each type
90e58ee
@BrettBlox
adds optional params from the prebid.js adapter
ed479ac
@BrettBlox
updates params test to include optional parameters
ca8dd13
@BrettBlox
fixes formatting
701edba
@BrettBlox
adds httpcalls to banner mock data
32b20c3
@BrettBlox
adds httpcalls to audio mock data
e8ed647
@BrettBlox
use correct endpoint
aaebf05
@BrettBlox
adds remaining properties for audio, video, and banner ad mocks
6a76468
@BrettBlox
adds additional invalid params entry
7b75b30
@BrettBlox
removes publisher id logic
5fa8d32
@BrettBlox
fixes json media type issue
1d48f83
@BrettBlox
removes unused import
ab5d56f
@BrettBlox
tests passing
cc8ab0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoinfive antoinfive antoinfive approved these changes

@walia walia walia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrettBlox @walia @antoinfive