Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jenkins testing and Gemnasium monitoring #409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamiemccarthy
Copy link
Contributor

@jamiemccarthy jamiemccarthy commented Apr 4, 2017

What does this do?

Previously autotune had been tested by Jenkins. But with the move to Jenkins 2.0 it got left behind. This PR:

  • adds it back into Jenkins' list of tested projects
  • adds automated Gemnasium vulnerability analysis

In addition to this PR, I've verified the Gemnasium project slug is correct, and added autotune into the Jenkins project-name regex.

More eyes wanted, please

Can someone who knows more about node than I do please see if these lines would make sense? And if so, uncomment them.

The Jenkinsfile here was basically copied from anthem, and I checked bin/test_docker_build.sh by eye, so I don't have any reason to think they won't work. But I'm not a Jenkins expert.

Deploy

Merging will suffice, no deploy is actually necessary (though shouldn't hurt of course).

Jenkins scans all voxmedia repositories periodically to determine which should appear in the Vox Media list. Until this merges, autotune won't appear, because it's missing a Jenkinsfile. After this merges, I think you can wait a few hours and then check the console to see if an automatic scan picked it up -- or I think you can open the configure page and probably just click Save to trigger an immediate scan.

@clifff
Copy link
Contributor

clifff commented Apr 5, 2017

It was a purposeful decision to not move autotune to Jenkins 2.0. This is a public repo and anybody could open up a PR with arbitrary code in a Jenkinsfile, which would automatically run on our Jenkins instance.

@jamiemccarthy
Copy link
Contributor Author

Ouch, good point. Thanks for clarifying Clif! I've taken it back out of the Jenkins repository name pattern.

@jamiemccarthy jamiemccarthy deleted the systems-push-gemnasium-update branch April 5, 2017 12:38
@ryanmark ryanmark restored the systems-push-gemnasium-update branch April 6, 2017 16:45
@ryanmark
Copy link
Contributor

ryanmark commented Apr 6, 2017

Reopening

@ryanmark ryanmark reopened this Apr 6, 2017
@ryanmark
Copy link
Contributor

ryanmark commented Apr 6, 2017

So this is 👍 to merge, however we need to find an alternate way to run these tests.

@clifff
Copy link
Contributor

clifff commented Apr 6, 2017

@ryanmark Just an idea - we could set up a specific Jenkins job that only runs on master, but not automatically against pull requests

@ryanmark
Copy link
Contributor

ryanmark commented Apr 6, 2017

@clifff thats doable, altho the PR tests are nice - could we put the jenkins file elsewhere so it can't be changed via a public PR? would that address the security issue?

@clifff
Copy link
Contributor

clifff commented Apr 6, 2017

screenshot 2017-04-06 18 50 32

These are the configuration options on the Github Branch Source plugin we use to automatically build PRs. Given the wording here, I actually think that a PR opened by a non-Vox Media org user would be on a fork, and not automatically run. I'm all for merging this into master and doing some experiments to verify weather or not our concern applies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants