CB24FW-232: fix nrf cloud log processing #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
avyurtsev
commented
Oct 23, 2024
avyurtsev
commented
- Release semaphore on error and prevent the log processing thread from being locked forever
- Remove extra debug messages that may lead to undesired effects in situations with log message overflow
When the cloud (through the shadow) requests a change in the cloud-based logging level or the alert enable/disable flag, log at the INF level so it is always easy to see that the request was effective. See ticket for reasoning. Jira: IRIS-9151 Signed-off-by: Pete Skeggs <[email protected]>
CB24FW-232: - Release semaphore on error and prevent the log processing thread from being locked forever - Remove extra debug messages that may lead to undesired effects in situations with log message overflow Signed-off-by: Alexander Yurtsev <[email protected]>
vladimirkhusainov-emcraft
approved these changes
Oct 24, 2024
vladimirkhusainov-emcraft
merged commit 09e5e54
into
voxelbotics-v2.6.1-branch
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.