Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New plugin for consideration: Player Status LED #177

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

andrewpono
Copy link
Contributor

indicates player state by operating a GPIO LED: play = on, stop = off, pause = blink.

@balbuze
Copy link
Collaborator

balbuze commented Jan 24, 2023

hello
do you need?:

sudo apt-get update
# Install the required packages via apt-get. build-essential is required for epoll onoff depends on.
sudo apt-get -y install build-essential --no-install-recommends

Gpio-xxx plugins work without

@andrewpono
Copy link
Contributor Author

Yes, I know Gpio-xxx plugins install without the build essentials. However I could not install mine without this step, it fails every time during npm i stage. The error is related to epoll - could not locate make, or something close to it. The solution I used was to just copy epoll to the modules dir, but plugin submission does not work like that. If I knew how to get rid of build essentials I would in a heartbeat. I even thought about getting rid on the onoff module for that reason.

@balbuze
Copy link
Collaborator

balbuze commented Jan 24, 2023

So it fails to submit without it?

@andrewpono
Copy link
Contributor Author

Yes, if I follow the plugin submission procedure first thing it does during plugin installation step is npm i. This fails like I described, so the process does not go through.

@andrewpono
Copy link
Contributor Author

I think now that I have build essential already installed, it will let me submit without that line in the install.sh. Plugin installation from the UI must be somehow different since it works without build essential. Let me know if this is something I need to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants