Serialampcontroller 2.0.2

[7h0mas-R]

new PR as announced in #111 with tidied up history and re-submit

[balbuze]

please submit your plugin 'volumio plugin submit' with this code

[7h0mas-R]

This time I am 100% sure that I did. It finished and told me to create a PR which I did. Can it be an issue with my installation? Or can it be related to changing the Plugin type from "system_controller" to "system_hardware", pushing and calling "volumio plugin submit" again without creating a new PR?
Normally new commits will be integrated into existing PR, right?

I'm currently traveling, will only be able to try again next week

[balbuze]

If you install the plugin 'volumio plugin instalt' and then submit 'volumio plugin submit' you get this message. Something not very clear. In that case I re clone my github then submit....

[7h0mas-R]

Car broke down and I'm unexpectedly back home 😕
Tried your suggestion. Did remove my local repo, re-cloned and then directly resubmitted with volumio plugin submit.
I got the following response after npm finished installing dependencies:

This command will submit a plugin for publishing in the plugins store. Newly submitted plugins will be verified by the volumio team. After verification the plugin will be publically available on the beta channel. When the plugin is properly tested in the beta channel, it will be promoted to the stable channel, available to download by everyone. Every subsequent version of the plugin will alo be put in the beta channel, and will be promoted to the stable channel after testing. 

? do you want to change your version? (leave blank for default) 2.0.3
Compressing the plugin
No modules found, running "npm install"
[... npm output ...]
Plugin succesfully compressed
Plugin added
Plugin uploaded
Your plugin is submitted to the volumio plugins store. Please create a pull request to submit your changes. This is mandatory for the plugin to be verified or accepted for the stable channel. For help please go to: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

There were some warnings from npm, because serialport.io is not pre-built for RPi so it gets built locally and creates the warnings, but it builds just fine and the plugin works thereafter, if I then call volumio plugin install, so serialport.io must be working, since it does all the communication to the Amp.

The way I read the checklist, the plugin is not supposed to build anything by itself (via install.sh), but I assume that npm install building well established modules like serialport.io is OK?

Beside that everything looks completely normal like it did for my other plugin - so I am not sure, what could be wrong.
Is there any method, how I can verify that the intial volumio plugin submit worked? So far I was under the impression, that for the first submission I just have to wait for somebody to approve it. For subsequent submissions, I normally see the new submission immediately in the beta channel.

[7h0mas-R]

Car broke down and I'm unexpectedly back home...
Tried your suggestion and cloned a fresh local copy of my repo. Then I immediately issued volumio plugin submit and received below response:

This command will submit a plugin for publishing in the plugins store. Newly submitted plugins will be verified by the volumio team. After verification the plugin will be publically available on the beta channel. When the plugin is properly tested in the beta channel, it will be promoted to the stable channel, available to download by everyone. Every subsequent version of the plugin will alo be put in the beta channel, and will be promoted to the stable channel after testing. 

? do you want to change your version? (leave blank for default) 2.0.3
Compressing the plugin
No modules found, running "npm install"
[... deleted lengthy npm output ...]
Plugin succesfully compressed
Plugin added
Plugin uploaded
Your plugin is submitted to the volumio plugins store. Please create a pull request to submit your changes. This is mandatory for the plugin to be verified or accepted for the stable channel. For help please go to: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

npm install throws some warnings because there is no pre-built version of serialport.io for RPi and it needs to be built locally.
But it builds just fine and I can volumio plugin install and the plugin works as usual.
The way I read the checklist, the plugin is not supposed to build anything by itself via install.sh but npm install building modules is allowed - correct?
That was the only remarkable difference I've seen with my previous attempt and with submissions of my other plugin.

Is there any way to verify, if the first submit has worked? So far I was under the impression, that the first submission needs to be approved by somebody and that subsequent submissions appear immediately on the Beta-Channel (so those I can check right away).

[balbuze]

hello
Yes first submit needs to be approved... and I approved v2.0.3! Available in beta! Let me know if users feedback are good in order to release it as stable ;-)
Thanks for your contribution

[balbuze]

what can we do? Stable or we close it?

[7h0mas-R]

Did not get a lot of feedback recently (I think it is not used by too many people, since those amps are not too common) but those who had bug reports did not come back with any complaints after I fixed them - assume it works - I use it almost every day in my setup without issues as well :)
Last relevant post is this one - after that only requests for features I will not implement.

So I would tend to say put 2.0.11 on stable and close